@darrylyeo

Feedback regarding detection of mini-app hosts: • Option 1 (well-known query parameter) would be the worst because it’s another identifier apps need to hardcode and will be easily spoofed (akin to browser extension wallets setting `isMetaMask` to true on their `window.ethereum` object). Just continue to let apps specify custom params for themselves in `<meta name="fc:frame">` if they really need it. • Option 2 (message passing) is ideal but can be improved further – I recommend turning it into a two-way message system modeled after EIP-6963 to avoid race conditions. (Also while you’re at it, use EIP-6963 to announce Farcaster Wallet’s EIP-1193 object to the app for instant compatibility with existing wallet picker UIs.) • Option 3 (`isInMiniApp()` SDK function) – this is fine assuming apps don’t already have the SDK code-split from their main client-side bundle, but maybe redundant to Option 2.

2 replies

0 recast

4 reactions