@vitalik.eth
The contract here is a sublinear staking contract: if you are in the whitelist (specified as an ERC1155 collection), then you can stake N coins, and get a return of N ** 0.75 coins per slot, for as long as the contract has coins to pay for it. There is a fundedUntil mechanism that ensures that if the contract runs out of money, every staker gets rewarded for every slot up to the fundedUntil timestamp, and the mechanism doesn't turn into a fractional reserve.
https://github.com/ethereum/research/blob/master/sublinear_staking/code.vy
Bounty of total 2 ETH for identifying any bugs / vulnerabilities in the contract and proposing specific fixes, if multiple issues are found the bounty will be split based on severity.
Amount: 2 ETH
@bountybot
22 replies
99 recasts
458 reactions
@if
looks good overall, but I found a few potential issues:
1.
```vy
def _fundedUntil() -> uint256:
return (
self.liabilitiesLastUpdated
+ (staticcall STAKED_TOKEN_ADDRESS.balanceOf(self) - self.liabilities)
// max(self.totalPayoutPerSlot, 1)
```
If the contract’s balance of the staked token `balanceOf(self)` is less than the total liabilities `self.liabilities`, the subtraction will underflow, causing a revert on `_unstake` method. It might be okay, but it would be better to handle it properly.
2.
```vy
def stake(amount: uint256):
```
A user can stake an amount of 0, which could cause potential issues in other parts. I think adding an assertion `assert amount > 0` if staking a zero amount is not intended.
0 reply
0 recast
0 reaction