Ruslan Valeev (max-max)

Hi guys! Does anyone have already tried to run the code from today's lesson? I have one failed test there (test_multiple_orderExecute_zeroForOne_both - last assert with 60 tick: [FAIL. Reason: assertion failed: 10000000000000000 != 0] test_multiple_orderExecute_zeroForOne_both() (gas: 612203). Has anyone got this too?

• 1 reply
• 0 recasts
• 1 reaction

Hi guys! Does anyone have already tried to run the code from today's lesson? I have one failed test there (test_multiple_orderExecute_zeroForOne_both - last assert with 60 tick: [FAIL. Reason: assertion failed: 10000000000000000 != 0] test_multiple_orderExecute_zeroForOne_both() (gas: 612203). Has anyone got this too?

• 1 reply
• 0 recasts
• 1 reaction

that was the issue. lastTicks[key.toId()] = tickAfterExecutingOrder should be out of the loop in afterSwap() function (in the lesson it was inside). Thank you so much @haardikkk 🙏

• 1 reply
• 0 recasts
• 1 reaction

if you mean `lib/v4-periphery/lib/v4-core/src/test/PoolSwapTest.sol` and 97 and 98 rows. But in my file this two rows are on 69 and 70 rows respectively. And I commented them and all the other 5 tests passed (including two from part 1). Maybe here is the reason and my library is another version?

• 0 replies
• 0 recasts
• 0 reactions

Native env

• 0 replies
• 0 recasts
• 1 reaction